Closed jamesmbaazam closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 98.77%. Comparing base (
918ee12
) to head (fe32c96
). Report is 40 commits behind head on main.:exclamation: Current head fe32c96 differs from pull request most recent head 9e349f0. Consider uploading reports for the commit 9e349f0 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Super! Just one comment: would it make sense to add a
setequal
test (as in the example)? That way we can make sure the two implementations don't diverge.
Thanks, that makes sense. I've made the change here 15f10d2180ae80467f0d8c2c4521629d8bf71da7.
Please check if the PR fulfils these requirements
[x] I have read the CONTRIBUTING guidelines
[x] The commit message follows our guidelines
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A feature.
summary.epichains_tree
method calculates the max generation, number of unique infectors from the<epichains_tree>
object.The
summary.epichains_tree
now returnsepichains_summary
with the same results assimulate_summary()
No, since this package is not released.
This PR closes #119.