search

epiverse-trace / epidemics

A library of published compartmental epidemic models, and classes to represent demographic structure, non-pharmaceutical interventions, and vaccination regimes, to compose epidemic scenarios.
https://epiverse-trace.github.io/epidemics/
Other
8 stars 2 forks source link

Model functions take model-specific parameters/arguments #114

Closed pratikunterwegs closed 9 months ago

pratikunterwegs commented 11 months ago

This issue is to flag that model-specific arguments and parameters are currently passed to the <infection> object, and should be passed to the model function instead, to make it clearer to users what the model requires.

E.g.

model_ebola_r(population, infection, p_hosp = 0.5, <other params>)

rather than passing p_hosp to the <infection>.

pratikunterwegs commented 10 months ago

Hi @bahadzie, since this is related to #133 and will also affect much of the codebase, including needing a re-writing of the vignettes, I can take this up along with that issue.