Threshold for validating a population object.

epiverse-trace / epidemics

A library of published compartmental epidemic models, and classes to represent demographic structure, non-pharmaceutical interventions, and vaccination regimes, to compose epidemic scenarios.

https://epiverse-trace.github.io/epidemics/

Other

8 stars 2 forks source link

Threshold for validating a population object. #118

Closed Degoot-AM closed 7 months ago

Degoot-AM commented 11 months ago

Small numerical residue in sum of population = 1.000001, raises validation error. "initial_conditions rows must always sum to 1.0". In the code you have set the threshold for validation to 1e-6, but this can be reduce, e.g., to 1e-3.

pratikunterwegs commented 11 months ago

Thanks @Degoot-AM - happy for you to make a PR and make this change.

pratikunterwegs commented 7 months ago

Hi @Degoot-AM - just checking whether you would be taking this up or should I move ahead with working on a fix?

Degoot-AM commented 7 months ago

Hi @pratikunterwegs , Welcome back. This is a small issue, I don't think it worth a PR. So fell free to fix it, by reducing the threshold. Thank you