remove default value in population function

epiverse-trace / epidemics

A library of published compartmental epidemic models, and classes to represent demographic structure, non-pharmaceutical interventions, and vaccination regimes, to compose epidemic scenarios.

https://epiverse-trace.github.io/epidemics/

Other

8 stars 2 forks source link

remove default value in population function #124

Closed jamesmbaazam closed 11 months ago

jamesmbaazam commented 11 months ago

This PR fixes #123. The context is explained in the linked issue.

pratikunterwegs commented 11 months ago

Thanks @jamesmbaazam - after looking at this, I think a better fix (to my own mistake, ofc) would be to leave the contact_matrix, demography_vector, and initial_conditions missing, similar to constructors e.g. infection(), vaccination(). That way users have to be explicit about the population characteristics. Could you make that change, and potentially changes to files where I may have used the current functionality?

jamesmbaazam commented 11 months ago

Okay, I'll do that now. See 91cde8952dc1259f58f15eb1a29a7add9556f424. I couldn't find any usage elsewhere.