epiverse-trace / epidemics

A library of published compartmental epidemic models, and classes to represent demographic structure, non-pharmaceutical interventions, and vaccination regimes, to compose epidemic scenarios.
https://epiverse-trace.github.io/epidemics/
Other
8 stars 2 forks source link

Add vignette comparing with {finalsize} #128

Closed pratikunterwegs closed 10 months ago

pratikunterwegs commented 11 months ago

This PR fixes #33.

github-actions[bot] commented 11 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)

github-actions[bot] commented 11 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)

adamkucharski commented 11 months ago

Thanks for sharing. I think we need to do more to make it really clear up front in the opening paragraph what the reader will get out of this vignette (especially as we'll likely have quite a few for this package, and need to help users know which ones most relevant).

It seems that the two main areas of comparison to frame the piece around are:

  1. Which tasks sit best in finalsize and epidemics, and how to switch between (e.g. if user has a finalsize model that implicitly assumes vaccination upfront but wants to convert into an epidemics model to explore roll out, or epidemics model but wants to simplify for computational speed)
  2. Relative speed, and context. For one off simulations, fractional differences of a second won't make much difference, so could give example for context - e.g. if do a simple 1000 value parameter sweep on R0, how long would final size take can epidemics?

For me, the numerical accuracy comparisons are least relevant here, because already explored in finalsize documentation, and could be confusing to include mix comparison with different model structures and solver methods (and beyond scope of interest for most target users of this package).

pratikunterwegs commented 11 months ago

Thanks - I'll do some restructuring over the next few days to focus on those points.

github-actions[bot] commented 11 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)

github-actions[bot] commented 10 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)

pratikunterwegs commented 10 months ago

Made some changes to this vignette to highlight different use cases for finalsize and epidemics, hopefully this is more useful @adamkucharski? Happy to incorporate more feedback.

github-actions[bot] commented 10 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)

github-actions[bot] commented 10 months ago

This pull request:

(cc @Bisaloo for workflow monitoring)