epiverse-trace / epimodelac

Training materials for the epimodelac workshop
https://epiverse-trace.github.io/epimodelac/
Other
8 stars 4 forks source link

wrong suggest to add {sandpaper} and {pegboard} when using sandpaper::update_cache() #10

Closed avallecam closed 12 months ago

avallecam commented 12 months ago

After solving #7 and #8 , when using sandpaper::update_cache() I get a request to update {sandpaper} and {pegboard} which should not be part of the renv.lock file.

> sandpaper::update_cache()
- Project '~/0projects/Nuevoformato' loaded. [renv 1.0.0; using profile 'lesson-requirements']
- One or more packages recorded in the lockfile are not installed.
- Use `renv::status()` for more details.
- Querying repositories for available binary packages ... Done!
- Querying repositories for available source packages ... Done!
- Checking for updated packages ... Done!
- 9 packages have updates available.

# CRAN -----------------------------------------------------------------------
- bslib       [0.6.0 -> 0.6.1]
- crosstalk   [1.2.0 -> 1.2.1]
- deSolve     [1.38 -> 1.40]
- nlme        [3.1-163 -> 3.1-164]
- QuickJSR    [repo: RSPM -> CRAN; ver: 1.0.7 -> 1.0.8]
- scales      [1.2.1 -> 1.3.0]

# carpentries ----------------------------------------------------------------
- pegboard    [repo: https://carpentries.r-universe.dev -> carpentries; ver: 0.7.1 -> 0.7.3]
- stringi     [repo: RSPM -> carpentries; ver: 1.8.1 -> 1.8.2]

# carpentries_archive --------------------------------------------------------
- sandpaper   [repo: https://carpentries.r-universe.dev -> carpentries_archive; ver: 0.14.0 -> 0.14.1.9000]
Bisaloo commented 12 months ago

This happens because sandpaper is used here: https://github.com/Joskerus/Nuevoformato/blob/bcf0bfecb6cec86cbf48c28557966eadcd90f6c3/episodes/EnfermedadX.Rmd#L331

avallecam commented 12 months ago

After removing it in https://github.com/Joskerus/Nuevoformato/commit/37e8650c81cdff63ca2c536de9aec9ffe106ded5, this suggestion does not change. I also updated these packages locally. But I think we can omit to update the cache until necessary.

Bisaloo commented 12 months ago

I don't seem to be able to reproduce this locally

avallecam commented 12 months ago

Thank you for your report. After a git pull I run sandpaper::build_lesson() and it updated the renv.lock as reported in #11. But, when I run sandpaper::update_cache() the suggestion for sandpaper and pegboard still appears but slightly different:

# carpentries --------------------------------
- pegboard     [repo: https://carpentries.r-universe.dev -> carpentries; ver: 0.7.1 -> 0.7.3]
- sandpaper    [repo: https://carpentries.r-universe.dev -> carpentries; ver: 0.14.0 -> 0.15.0]

I took the opportunity of the repo rename to clone it locally in a new folder. This message was not reproducible in this new clone.

I'll close this. This seems to be solved with a fresh new local clone of the repo.