search

epiverse-trace / epiparameter

R package with library of epidemiological parameters for infectious diseases and functions and classes for working with parameters
https://epiverse-trace.github.io/epiparameter
Other
32 stars 11 forks source link

Set up infrastructure to translate print() methods #367

Closed Bisaloo closed 1 month ago

Bisaloo commented 1 month ago

Fix #116.

We still need native speakers to do the actual translation, as documented in https://michaelchirico.github.io/potools/articles/translators.html but this sets up the necessary infrastructure.

joshwlambert commented 1 month ago

@Bisaloo this PR is still a draft, but from what I can see it is ready to be merged unless we want to include any translations within this PR. Can we set the PR as ready to review so it can be merged?

Bisaloo commented 1 month ago

It would be good to discuss what the process should be around trying to add translations to the packages. I.e. should we add a line to the README about accepting translation contributions, should we be aiming to add translations for a core set of languages within Epiverse (e.g. es, fr)?

Could you share this on the #community channel on slack please? I believe it needs to involve a larger group.

@Bisaloo this PR is still a draft, but from what I can see it is ready to be merged unless we want to include any translations within this PR. Can we set the PR as ready to review so it can be merged?

Sounds good to me. It was marked as draft to insist on the fact it was low pressure and could easily be delayed/closed if it didn't seem like the best solution.

joshwlambert commented 1 month ago

The test-coverage workflow is failing and has been sporadically failing since #366. It doesn't relate to this PR so I will go ahead and merge it, and then figure out a solution to apply in a separate PR.