epiverse-trace / episoap

[Not published - under active development] A Store of Outbreak Analytics Pipelines Provided as Rmarkdown Report Templates
https://epiverse-trace.github.io/episoap/
Other
4 stars 2 forks source link

Use linelist data source in transmissibility report #137

Closed Bisaloo closed 2 months ago

Bisaloo commented 3 months ago

Fix #89

It's slightly annoying and not ideal that the code changes like this between the case when we use individual level data vs aggregated data.

This means users may now wonder how to use aggregated data :weary:

Tagging @joshwlambert for review as you opened the original issue. Tagging @CarmenTamayo for review as package author.

CarmenTamayo commented 3 months ago

Fix #89

It's slightly annoying and not ideal that the code changes like this between the case when we use individual level data vs aggregated data.

This means users may now wonder how to use aggregated data 😩

Tagging @joshwlambert for review as you opened the original issue. Tagging @CarmenTamayo for review as package author.

Hi Hugo thanks for this, I'm going to look into it this afternoon

codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.07%. Comparing base (d36b447) to head (2b2ff0f). Report is 5 commits behind head on main.

:exclamation: Current head 2b2ff0f differs from pull request most recent head 4b80aca. Consider uploading reports for the commit 4b80aca to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage 73.07% 73.07% ======================================= Files 4 4 Lines 26 26 ======================================= Hits 19 19 Misses 7 7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.