epiverse-trace / episoap

[Not published - under active development] A Store of Outbreak Analytics Pipelines Provided as Rmarkdown Report Templates
https://epiverse-trace.github.io/episoap/
Other
4 stars 2 forks source link

Epicurves description in transmissibility report #139

Closed CarmenTamayo closed 2 months ago

CarmenTamayo commented 2 months ago

The report template for transmissibility currently describes that the section "Epidemic curves" generates these curves with or without stratification, however the provided code and resulting epicurves only show stratified epicurves and total no. of cases

@Bisaloo should we also add the total incidence across regions, or remove the "without stratification" bit? I think we could simply add an overall epicurve/total no. of cases graph to the existing ones

Bisaloo commented 2 months ago

@Bisaloo should we also add the total incidence across regions, or remove the "without stratification" bit?

I don't have a strong preference. Both options sound reasonable and I'm happy to let you decide.

CarmenTamayo commented 2 months ago

Hi @Bisaloo , I've noticed that on the package's vignette there's indeed an epicurve with overall cases, but this seems to be no longer available on the current template's code- was there a reason for this can you remember? I'll try find the og code

CarmenTamayo commented 2 months ago

Fixed in #144

Bisaloo commented 2 months ago

Context: this was removed from incidence2 for a while but have been reintroduced in https://github.com/reconverse/incidence2/commit/cda7bf02f08fb85710f9d4d77662fa8c190f7330.