Open Bisaloo opened 2 months ago
@Bisaloo - this looks good to me. Below is what I think about the points you raised:
how to deal with already existing template files (overwrite, use or error?) in out_dir?
I suggest to compare it with the corresponding template in the package and:
should we pass a path to the data (saved on the local computer), or a data object directly?
I prefer the data object due to the following:
what to preview when multiple reports are created?
Maybe provide more clarification here if possible. Are you referring to a scenario where severity and transmissibility is executed? or where transmissibility is executed with the different methods?
Are you referring to a scenario where severity and transmissibility is executed
Yes, this. The preview
option will open the HTML report in a browser window. Currently it only opens the first report but we could potentially open one tab per report. Not completely if it makes sense though, and not sure which tab should be active then.
Are you referring to a scenario where severity and transmissibility is executed
Yes, this. The
preview
option will open the HTML report in a browser window. Currently it only opens the first report but we could potentially open one tab per report. Not completely if it makes sense though, and not sure which tab should be active then.
Then I think one report with multiple tabs will be better. {reactable} allows for this but I have not yet figured out how not to show the severity tab (which will be empty) if the severity template is not executed.
Then I think one report with multiple tabs will be better. {reactable} allows for this but I have not yet figured out how not to show the severity tab (which will be empty) if the severity template is not executed.
This should be achievable through rmdscaffold. Can it wait until episoap 0.2.0?
Please check if the PR fulfills these requirements
[x] I have read the CONTRIBUTING guidelines
[ ] A new item has been added to
NEWS.md
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] Checks have been run locally and pass
This is a first proposal for a simple
run_pipeline()
function. We can iterate on it as long as necessary, with the constraint that we won't touch the reports, or write any epi code here.Specific points to discuss:
out_dir
Could also be used to solve #51, #88.
TODO: