epiverse-trace / episoap

[Not published - under active development] A Store of Outbreak Analytics Pipelines Provided as Rmarkdown Report Templates
https://epiverse-trace.github.io/episoap/
Other
4 stars 2 forks source link

Add `run_pipeline()` first draft #149

Open Bisaloo opened 2 months ago

Bisaloo commented 2 months ago

This is a first proposal for a simple run_pipeline() function. We can iterate on it as long as necessary, with the constraint that we won't touch the reports, or write any epi code here.

Specific points to discuss:

Could also be used to solve #51, #88.

TODO:

Karim-Mane commented 2 months ago

@Bisaloo - this looks good to me. Below is what I think about the points you raised:

how to deal with already existing template files (overwrite, use or error?) in out_dir?

I suggest to compare it with the corresponding template in the package and:

should we pass a path to the data (saved on the local computer), or a data object directly?

I prefer the data object due to the following:

what to preview when multiple reports are created?

Maybe provide more clarification here if possible. Are you referring to a scenario where severity and transmissibility is executed? or where transmissibility is executed with the different methods?

Bisaloo commented 2 months ago

Are you referring to a scenario where severity and transmissibility is executed

Yes, this. The preview option will open the HTML report in a browser window. Currently it only opens the first report but we could potentially open one tab per report. Not completely if it makes sense though, and not sure which tab should be active then.

Karim-Mane commented 2 months ago

Are you referring to a scenario where severity and transmissibility is executed

Yes, this. The preview option will open the HTML report in a browser window. Currently it only opens the first report but we could potentially open one tab per report. Not completely if it makes sense though, and not sure which tab should be active then.

Then I think one report with multiple tabs will be better. {reactable} allows for this but I have not yet figured out how not to show the severity tab (which will be empty) if the severity template is not executed.

Bisaloo commented 2 months ago

Then I think one report with multiple tabs will be better. {reactable} allows for this but I have not yet figured out how not to show the severity tab (which will be empty) if the severity template is not executed.

This should be achievable through rmdscaffold. Can it wait until episoap 0.2.0?