search

epiverse-trace / epiverse-trace.github.io

Technical blog of the Epiverse-TRACE project, where we share opinions and investigations in R package development, or scientific software development more generally
https://epiverse-trace.github.io/
3 stars 3 forks source link

Add acknowledgements to release posts #273

Closed chartgerink closed 2 weeks ago

chartgerink commented 1 month ago

This PR adds an auto-generated acknowledgements section to the release posts. It also adds the relevant packages to the github action, in order to ensure it can be run (usethis and glue).

Fixes #197.

netlify[bot] commented 1 month ago

Deploy Preview for tourmaline-marshmallow-241b40 ready!

Name Link
Latest commit acc1fb5629f694b7449a42f3951aeb96289e5bcd
Latest deploy log https://app.netlify.com/sites/tourmaline-marshmallow-241b40/deploys/6673d30496ba40000830fe08
Deploy Preview https://deploy-preview-273--tourmaline-marshmallow-241b40.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chartgerink commented 3 weeks ago

Thanks @Bisaloo! You're completely correct - I will adapt.

chartgerink commented 2 weeks ago

@Bisaloo - I updated the calls as requested. I ended up adding a gh call in the release.qmd to prevent propagating the properties from the workflow into the specific call.

chartgerink commented 2 weeks ago

@Bisaloo - thanks again for the feedback. Sorry for the back and forth on this - it appears this has a few more potholes than I expected (I told @joshwlambert it would be straightforward to do when first suggested!)

I updated the release acknowledgements to use the same heuristic as the workflow itself, discarding the patch versions as follows

  purrr::discard(~ grepl("\\d+\\.\\d+\\.[1-9]\\d*$", .x$tag_name))

This helped me address the inconsistent release naming across repo's at the same rate as the workflow is able to do it. I figured consistency would be better here than diverging 👍

joshwlambert commented 2 weeks ago

Thanks both for implementing this request, hopefully it'll make it easier to keep track of acknowledging contributors, especially as more people engage with the packages.