search

epiverse-trace / serofoi

Estimates the Force-of-Infection of a given pathogen from population based sero-prevalence studies
https://epiverse-trace.github.io/serofoi/
Other
17 stars 4 forks source link

remove dependencies devtools and usethis #128

Closed ntorresd closed 11 months ago

Bisaloo commented 11 months ago

Hi @ntorresd, this is the only PR I see as needed to be merged before epimodelac. As @davidsantiagoquevedo mentioned during our last development meeting, devtools can be tricky to install for some users due to its system dependencies. Let's ensure we remove this potential source of issues ahead of the workshop.

I see this PR has accumulated some conflicts and unrelated commits. If you're short on time, I'm happy to clean this branch myself so this can get merged.

ntorresd commented 11 months ago

I see this PR has accumulated some conflicts and unrelated commits. If you're short on time, I'm happy to clean this branch myself so this can get merged.

I would really appreciate that! Thanks for offering your help for this.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6706d1f) 76.77% compared to head (ac6cbcf) 76.83%.

:exclamation: Current head ac6cbcf differs from pull request most recent head 58c107e. Consider uploading reports for the commit 58c107e to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #128 +/- ## ========================================== + Coverage 76.77% 76.83% +0.06% ========================================== Files 10 10 Lines 1563 1563 ========================================== + Hits 1200 1201 +1 + Misses 363 362 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Bisaloo commented 11 months ago

This is now ready for review.