search

epiverse-trace / serofoi

Estimates the Force-of-Infection of a given pathogen from population based sero-prevalence studies
https://epiverse-trace.github.io/serofoi/
Other
17 stars 4 forks source link

Simplify `get_prev_expanded()` #135

Closed Bisaloo closed 10 months ago

Bisaloo commented 11 months ago

This function includes unnecessary loops that make it difficult to understand what's happening. I'm still not 100% sure this is the intended behaviour of this function but this PR does not change it. The result is the same as what main currently gives.

As always, I recommend reviewing this PR commit by commit since each commit focuses on a specific area of change.

codecov-commenter commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (6706d1f) 76.77% compared to head (fd4891d) 76.65%.

:exclamation: Current head fd4891d differs from pull request most recent head 56d28cf. Consider uploading reports for the commit 56d28cf to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== - Coverage 76.77% 76.65% -0.12% ========================================== Files 10 10 Lines 1563 1555 -8 ========================================== - Hits 1200 1192 -8 Misses 363 363 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.