Closed ntorresd closed 1 year ago
Thanks @ntorresd. Can I just check, are all the 90 files which have been changed here relating to the
get_sim_counts
andgenerate_sim_data
functions? If not, can some of this PR be partitioned into different PRs? Otherwise, this will be a monster to review.
Hi @ben18785 !
I'll refer to your comment here. The previous PR was intended to solve conflicts between dev and main. This one is to update main.
I think you're right. I hadn't realized the huge amount of changes I introduced with this PR at first. It might be better to atomize this update in smaller chunks for it to be easier to review...
The only changed files relating to the data simulation functions should've been R/seroprevalence_data.R , tests/testthat/test_simulate_data.R and their corresponding documentation files.
The primary features added in this commit are the data simulation functions:
get_sim_counts
generate_sim_data
group_sim_data
The corresponding test for this functions is added. Tests for the modelling module are updated. Test regarding issue #47 is added. Minor changes were done to the documentation, in particular: