epiverse-trace / serofoi

Estimates the Force-of-Infection of a given pathogen from population based sero-prevalence studies
https://epiverse-trace.github.io/serofoi/
Other
17 stars 4 forks source link

main <- dev: add data simulation functions. #79

Closed ntorresd closed 1 year ago

ntorresd commented 1 year ago

The primary features added in this commit are the data simulation functions:

ntorresd commented 1 year ago

Thanks @ntorresd. Can I just check, are all the 90 files which have been changed here relating to the get_sim_counts and generate_sim_data functions? If not, can some of this PR be partitioned into different PRs? Otherwise, this will be a monster to review.

Hi @ben18785 !

I'll refer to your comment here. The previous PR was intended to solve conflicts between dev and main. This one is to update main.

I think you're right. I hadn't realized the huge amount of changes I introduced with this PR at first. It might be better to atomize this update in smaller chunks for it to be easier to review...

The only changed files relating to the data simulation functions should've been R/seroprevalence_data.R , tests/testthat/test_simulate_data.R and their corresponding documentation files.