Closed ntorresd closed 1 year ago
Merging #83 (cdd44a6) into main (d7f66d7) will decrease coverage by
3.03%
. The diff coverage is11.11%
.:exclamation: Current head cdd44a6 differs from pull request most recent head 72ea70b. Consider uploading reports for the commit 72ea70b to get more accurate results
@@ Coverage Diff @@
## main #83 +/- ##
==========================================
- Coverage 82.18% 79.16% -3.03%
==========================================
Files 10 10
Lines 1684 1747 +63
==========================================
- Hits 1384 1383 -1
- Misses 300 364 +64
Files Changed | Coverage Δ | |
---|---|---|
R/seroprevalence_data.R | 41.41% <0.00%> (-58.59%) |
:arrow_down: |
R/visualisation.R | 54.22% <57.14%> (-1.90%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I'm not sure I understand the logic behind including the various svg files: do we actually want a user to have access to these? Also, I'm not sure about the various hardcoded FOI datasets within here... If we have a function for simulating these, I'd say we can just remove them.
Hi @ben18785. The reason for this is simply because currently we're using some of these datasets here to exemplify the use of the library. We could eventually add the data simulation process to the vignettes, but we need these hardcoded datasets for the time being.
@ntorresd -- I understand that we need ways to visualise data, but these svgs are filling up the repo. Surely we can just use a package function (or ggplot) to visualise the serology data?
This PR partly closes #57
fix: add exception to function plot_foi() to plot a FOI trend with different length along with the data for the case when their sizes don't coincide
clean test_visualisation
feature: add three functions to simulate datasets. get_sim_counts() generates a list with simulated counts by age following a binomial distribution. generate_sim_data() uses the counts generated by get_sim_counts() to create a dataframe with the necessary structure to use other functions of the package. group_sim_data() serves to group the previously generated dataset by age group; right now it groups the data by periods of 5 years.
add test_simulate_data to test the data simulation functions in the seroprevalence_data module