search

epiverse-trace / tutorials-middle

https://epiverse-trace.github.io/tutorials-middle/
Other
3 stars 1 forks source link

Test Spanish translation via babeldown #95

Closed Bisaloo closed 2 weeks ago

Bisaloo commented 4 weeks ago

@avallecam, no need for an actual review but could you browse this quickly for a simple high-level check?

If it sounds good, I can:

For reference, to translate two episodes, I used almost 10% of my free monthly characters. Translating all lessons in a short amount of time may indeed require paying for DeepL, at least for 1 month.

Since babeldown is not really designed for the workbench, I had a couple of minor issue. I will coordinate with Maëlle in the coming months to see if we can streamline the process even more:

Post-processing:

sed -i -r 's/(:+) llamada/\1 callout/g' *
sed -i -r 's/(:+) objetivos/\1 objectives/g' *
sed -i -r 's/(:+) preguntas/\1 questions/g' *
sed -i -r 's/(:+) prerrequisito/\1 prereq/g' *
sed -i -r 's/(:+) puntos clave/\1 keypoints/g' *
sed -i -r 's/(:+) desafío/\1 challenge/g' *
sed -i -r 's/(:+) lista de control/\1 checklist/g' *
sed -i -r 's/(:+) discusión/\1 discussion/g' *
sed -i -r 's/(:+) testimonio/\1 testimonial/g' *
github-actions[bot] commented 4 weeks ago

Thank you!

Thank you for your pull request :smiley:

:robot: This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

Rendered Changes

:mag: Inspect the changes: https://github.com/epiverse-trace/tutorials-middle/compare/md-outputs..md-outputs-PR-95

The following changes were observed in the rendered markdown documents:

 config.yaml (new) |   86 ++
 renv.lock (new)   | 2419 +++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 2505 insertions(+)
What does this mean? If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

:stopwatch: Updated at 2024-07-05 12:26:42 +0000

avallecam commented 4 weeks ago

this looks good! I briefly skim through them, and they look appropriate to review by a Spanish speaker.

One step after the DeepL translation I see is to recover the callout tags to English manually (e.g., questions, prerequisites here in spanish back to english)

For the DeepL assessment, I need to specify the exact four episodes to translate in this first batch:

Let us know if the characters in these four episodes overpass the limit in the amount of characters

avallecam commented 4 weeks ago

All these pre-translations look appropriate. It is nice to see that it is possible to add the post-processing tags; they work nicely. Do you have the % of monthly characters used for all these?

Some next-step questions:

Bisaloo commented 4 weeks ago

I have used 150k / 500k characters from my monthly quota. I used a bit more than I should have because of the small bugs mentioned in the first message, which required some debugging and trial and error.

Translations are currently located in the folder locale/es/episodes. Do we expect them to live here?

Probably yes at this time to facilitate deployment but it may change in the future. Especially as the Carpentries start standardizing their process, we will want to follow the choice they end up doing.

Is this an appropriate PR to request a translation review?

Yes, it's fine with me. Do what you think is best.

avallecam commented 4 weeks ago

Translations are currently located in the folder locale/es/episodes. Do we expect them to live here?

Probably yes at this time to facilitate deployment but it may change in the future. Especially as the Carpentries start standardizing their process, we will want to follow the choice they end up doing.

Sure, I agree. Some additional ones:

With the current path:

avallecam commented 4 weeks ago
  • Have you tried to render these translations locally? To make any needed final tweaks. I'm now trying to run sandpaper::build_lesson() to see what happens.

Locally difficult to assess given long-time runs.

My current workflow would be to:

Bisaloo commented 4 weeks ago

Ok, let's do this for now because I don't have availability to investigate more

avallecam commented 3 weeks ago

Dear reviewers, thank you for volunteering to review the automatic translation of one episode:

The translated files are accessible in the "Files changed" tab of this PR.

We are open to accepting your specific changes to one or multiple lines using the "Files changed" tab. To start your review, you can follow steps 5 to 8 from this how-to guide on Reviewing proposed changes in a pull request.

If you prefer an alternative method for review, please let me know, and we can coordinate another platform according to your needs. Each episode could be reviewed on different platforms.

Lastly, we mostly want your review of the Spanish translation of the text. If you have a thematic or technical improvement you would like the tutorials to have, please feel free to fill an issue.

We aim to have all translations reviewed by the 4th of July.

avallecam commented 2 weeks ago

thank you all for your review. I'll start to accept comments or spin off any interesting question or topic as an issue to assess later.

avallecam commented 2 weeks ago

all changes added. now this is ready to merge 🚀 thank you all!