epk / SF-Mono-Nerd-Font

Apple's SF Mono font patched with the Nerd Fonts patcher
514 stars 50 forks source link

Installation broken with latest Homebrew due to `livecheck` changes #5

Closed karimbenbourenane closed 1 year ago

karimbenbourenane commented 1 year ago

Recent changes to Homebrew require a different way of using the livecheck method in Cask formulae. When attempting to install, currently, output errors like this:

❯ brew install font-sf-mono-nerd-font 
==> Downloading https://formulae.brew.sh/api/formula.jws.json

==> Downloading https://formulae.brew.sh/api/cask.jws.json

Warning: Cask 'font-sf-mono-nerd-font' is unreadable: wrong number of arguments (given 1, expected 0)
==> Searching for similarly named formulae and casks...
Error: Cask 'font-sf-mono-nerd-font' is unreadable: wrong number of arguments (given 1, expected 0)

To fix this, I had to edit the formula for this Cask and modify this line:

livecheck 'https://github.com/epk/SF-Mono-Nerd-Font/releases.atom'

Instead, I use the following:

  livecheck do
    url :url
    strategy :github_latest
  end

This change allows installation to succeed.

kkiani commented 1 year ago

I am facing the same issue

epk commented 1 year ago

Fixed in https://github.com/epk/homebrew-epk/commit/3e2ad69d1e369818fd484c95ac3a3604ca33b901