search

epoberezkin / fast-deep-equal

The fastest deep equality check with Date, RegExp and ES6 Map, Set and typed arrays support
MIT License
1.86k stars 101 forks source link

toString comparison breaks if object has toString that isn't a function #141

Open master-elodin opened 9 months ago

master-elodin commented 9 months ago

If there is data passed into equals that has toString as a field that's not a function, equals breaks because it tries to call it as a function.

Example data: { field: "status", fieldtype: "jira", fieldId: "status", from: "10000", fromString: "To Do", to: "3", toString: "In Progress" }

I know that it's not ideal to have a field named toString, but this is external data that I don't have any control over.

master-elodin commented 9 months ago

Actually, it looks like there's a PR that's been open for this since August 2022 - https://github.com/epoberezkin/fast-deep-equal/pull/134