Update Benchmark for LTS Node Version

epoberezkin / fast-deep-equal

The fastest deep equality check with Date, RegExp and ES6 Map, Set and typed arrays support

MIT License

1.89k stars 101 forks source link

Update Benchmark for LTS Node Version #143

Open cjlludwig opened 7 months ago

cjlludwig commented 7 months ago

Definitely a nitpick but would love to see the README / benchmark logic updated to the LTS Node version!

https://nodejs.org/en/download

https://github.com/epoberezkin/fast-deep-equal/blob/master/README.md#performance-benchmark

benasher44 commented 6 months ago

Performance improvements were made to isDeepStrictEqual as of node 18, so it would be great to see this updated https://github.com/nodejs/node/commits/main/lib/internal/util/comparisons.js

electrovir commented 2 months ago

I tried running benchmarks and they error out on Node.js v18, v20, and v22 with lots of "different result" errors and also "require() of ES Module not supported".