search

epoberezkin / fast-json-stable-stringify

Deterministic JSON.stringify() - a faster version of @substack's json-stable-strigify without jsonify.
Other
285 stars 34 forks source link

Reduce the size of the npm package by limiting the included files #2

Open paazmaya opened 5 years ago

paazmaya commented 5 years ago

Looks like the files property (https://docs.npmjs.com/files/package.json#files) is not used in package.json to specify the included files, nor is the .npmignore file (https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package) is being used for blacklisting unwanted files, for the package published to npm.

Would you consider adding either the files property or the .npmignore file, so that the resulting package file would have smaller size?

The current size can be seen when executing the command npm pack (https://docs.npmjs.com/cli/pack).

This issue was create via tawata

knksmith57 commented 5 years ago

for reference:

❯ npm view fast-json-stable-stringify dist.tarball | xargs curl -sS | tar -tz
package/package.json
package/.npmignore
package/README.md
package/LICENSE
package/index.js
package/.travis.yml
package/.eslintrc.yml
package/benchmark/index.js
package/benchmark/test.json
package/example/key_cmp.js
package/example/nested.js
package/example/str.js
package/example/value_cmp.js
package/test/cmp.js
package/test/nested.js
package/test/str.js
package/test/to-json.js
epoberezkin commented 5 years ago

Files property is ok

knksmith57 commented 5 years ago

just touching base, @epoberezkin, to let you know that I worked a small PR to address these concerns: #4.

please let me know if there's anything else I can do! thanks!

JackHowa commented 1 year ago

curious about this @epoberezkin