Add native Node.js ES Modules support

epoberezkin / fast-json-stable-stringify

Deterministic JSON.stringify() - a faster version of @substack's json-stable-strigify without jsonify.

Other

288 stars 34 forks source link

Add native Node.js ES Modules support #20

Closed abdonrd closed 3 years ago

abdonrd commented 4 years ago

In this PR I add native Node.js ES Modules support.

Following the same recommendations as the Rollup plugins:

Fix #8.

coveralls commented 4 years ago

Coverage decreased (-1.1%) to 98.876% when pulling cda18621fb526e41f031e688b220711c11e0ba04 on abdonrd:native-esm into 49e230da2c84247b29ad4de02c9395793caefd15 on epoberezkin:master.

mzgajner commented 4 years ago

@epoberezkin is there any additional work that needs to be done to get this PR merged? I'd love to help.

It seems like a solid change and would unlock the use of the module with modern tools like vite and snowpack that rely on ES modules.

thescientist13 commented 3 years ago

Myself (and a few others from the issue discussion) would definitely appreciate this landing. 🙏

abdonrd commented 3 years ago

Closing because no response.

thescientist13 commented 3 years ago

sharing comments here from a similar thread for those following along https://github.com/epoberezkin/fast-json-stable-stringify/pull/10#issuecomment-878426865 👀