search

epoberezkin / fast-json-stable-stringify

Deterministic JSON.stringify() - a faster version of @substack's json-stable-strigify without jsonify.
Other
285 stars 34 forks source link

Improve typescript typing #41

Closed sxwei123 closed 3 years ago

sxwei123 commented 3 years ago

Add type definitions to opts, opts.cmp and opts.cycles.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling aab1c68d43f7b31b7e9740d3b5e1810794a78858 on sxwei123:master into 49e230da2c84247b29ad4de02c9395793caefd15 on epoberezkin:master.

epoberezkin commented 3 years ago

Hey @sxwei123 - looks cool :)

Is this PR opened by mistake or you propose to merge your fork back in?

epoberezkin commented 3 years ago

Most likely you just continued committing to the same branch where the original PR was opened from - correct?...

sxwei123 commented 3 years ago

@epoberezkin Oh sorry. I think I did something wrong. I created a new stringify package with Typescript and es6 based on your code. Please closed this PR.

sxwei123 commented 3 years ago

Create another PR to improve the comparator function typing: https://github.com/epoberezkin/fast-json-stable-stringify/pull/47

epoberezkin commented 3 years ago

No problem - I figured it was accidental - thanks for confirming!