search

epoberezkin / fast-json-stable-stringify

Deterministic JSON.stringify() - a faster version of @substack's json-stable-strigify without jsonify.
Other
288 stars 34 forks source link

ES module version #6

Open tirithen opened 5 years ago

tirithen commented 5 years ago

I need an ES module version of this package for a project. I simply created an esm.js copy of the CommonJS version.

I'm a bit unsure on how to setup a testing and linting so that both versions can co-exist without changeing the project structure too much, I'm all up for working on that if it sounds like a good idea if I can get some hints on which project structure you would like.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 7a3dcf2e086222fcee52d354d50a6a80dea97aed on tirithen:master into c9782fd4cb589c0196b36ab8b3eae18ad71ca43f on epoberezkin:master.

abdonrd commented 5 years ago

@epoberezkin any news here? Thanks!

tirithen commented 5 years ago

@abdonrd for now I use my pull request at https://github.com/tirithen/fast-json-stable-stringify directly in my package.json like this:

"fast-json-stable-stringify": "git+https://git@github.com/tirithen/fast-json-stable-stringify.git",

Importing/usage is identical, feel free to try that out if you want. :)

It would be even better if it was possible to get an ES6 version added directly into this repo. Lets hope that @epoberezkin can find the time.

abdonrd commented 5 years ago

@tirithen I create a PR to support both cases: https://github.com/epoberezkin/fast-json-stable-stringify/pull/10