epoch8 / airflow-exporter

Airflow plugin to export dag and task based metrics to Prometheus.
Other
240 stars 75 forks source link

fetch DAG stats from DagRun instead of DagStat #47

Closed sockeye44 closed 5 years ago

sockeye44 commented 5 years ago

fix for #46

elephantum commented 5 years ago

@sockeye44 thanks for the PR!

Question: do I understand correctly that this change breaks compatibility with Airflow versions before 1.10.3?

sockeye44 commented 5 years ago

As I understand it, it can break compatibility with some of the oldest versions, but the underlying tables/fields have been added years ago:

elephantum commented 5 years ago

Yes, this change breaks compatibility in a silent way: it does not crash, but returns no metrics on 1.10.0.

Let's discuss what can be done about that.

Maybe we can create special branch that supports 1.10.3(rc2)+ and leave current version with note of incompatibility with 1.10.3

elephantum commented 5 years ago

I will merge this PR into separate branch airflow-1.10.3 for now.

When 1.10.3 gets released, we will drop compatibility with previous versions and make a new release of airflow-exporter.