epoch8 / airflow-exporter

Airflow plugin to export dag and task based metrics to Prometheus.
Other
247 stars 75 forks source link

Deliver plugin as a python package #48

Closed maxbrunet closed 5 years ago

maxbrunet commented 5 years ago

I chose airflow-exporter/airflow_exporter as package name, but it's open to change. The tests should also be updated to use an installed package (pip install -e . for development and pip install . for CI tests).

Thank you for this nice plugin.

Closes #44

elephantum commented 5 years ago

@maxbrunet great job! We'll test it shortly

elephantum commented 5 years ago

@maxbrunet do I understand correctly, that Travis tests do not use this distribution by package?

maxbrunet commented 5 years ago

@maxbrunet do I understand correctly, that Travis tests do not use this distribution by package?

Yes, I'll work on that if I have time, else I'll leave it to you

maxbrunet commented 5 years ago

Hi @elephantum, I just pushed the updated tests, I took the liberty to do a lot of refactoring. A few things about it:

Hope you'll like the suggested setup.

elephantum commented 5 years ago

@maxbrunet Incredible job! I like your approach it's very elegant and clean.