Closed maxbrunet closed 5 years ago
@maxbrunet great job! We'll test it shortly
@maxbrunet do I understand correctly, that Travis tests do not use this distribution by package?
@maxbrunet do I understand correctly, that Travis tests do not use this distribution by package?
Yes, I'll work on that if I have time, else I'll leave it to you
Hi @elephantum, I just pushed the updated tests, I took the liberty to do a lot of refactoring. A few things about it:
matrix
feature to easily test more versions (everything should be configurable via environment variables)docker-compose.test.yml
docker-compose.yml
for development. There, it doesn't really install the package, but mounts the module directly in the user's site-packages (I haven't been able to make pip install --editable
work inside the container while mounting the local directory)CONTRIBUTING.md
file to document how to run the dev and test environmentsAIRFLOW__WEBSERVER__RBAC
environment variable is passed to tests container, if ever you need to check if RBAC is enabled or not from thereHope you'll like the suggested setup.
@maxbrunet Incredible job! I like your approach it's very elegant and clean.
setup.py
and related filesairflow_exporter
packageREADME.md
I chose
airflow-exporter
/airflow_exporter
as package name, but it's open to change. The tests should also be updated to use an installed package (pip install -e .
for development andpip install .
for CI tests).Thank you for this nice plugin.
Closes #44