search

epoch8 / airflow-exporter

Airflow plugin to export dag and task based metrics to Prometheus.
Other
247 stars 75 forks source link

Fix custom labels from params #93

Closed Brightside56 closed 3 years ago

Brightside56 commented 3 years ago

This PR is to fix custom labels from dag parameters

elephantum commented 3 years ago

@Brightside56 can you explain, please?

Does it mean that custom labels are currently broken?

Brightside56 commented 3 years ago

@Brightside56 can you explain, please?

Does it mean that custom labels are currently broken?

Yes, they're not working (you can take a look on docker-compose tests to check). This PR will fix them. current_app context isn't working for some reason

Brightside56 commented 3 years ago

@elephantum what about merging and releasing fix? Or should I use fork instead?

elephantum commented 3 years ago

@Brightside56 I dug deeper into this issue, proper fix will be released with #83

elephantum commented 3 years ago

Fixed in version 1.4.2