search

epochjs / epoch

A general purpose, real-time visualization library.
http://epochjs.github.io/epoch
MIT License
4.97k stars 278 forks source link

Add the ability to set fixed ranges for time graphs #132

Closed willwhitney closed 10 years ago

willwhitney commented 10 years ago

Analogous to https://github.com/fastly/epoch/pull/117/, and so it's exactly the same change.

Additionally, removed the redundant y() function in time/line to avoid having to duplicate that change in another place.

rsandor commented 10 years ago

@willwhitney - Just letting you know I've seen this, looks good. Going to review / test sometime later this week.

Cheers!

willwhitney commented 10 years ago

Awesome, thanks!

On Mon, Aug 11, 2014 at 6:23 PM, Ryan Sandor Richards < notifications@github.com> wrote:

@willwhitney https://github.com/willwhitney - Just letting you know I've seen this, looks good. Going to review / test sometime later this week.

Cheers!

— Reply to this email directly or view it on GitHub https://github.com/fastly/epoch/pull/132#issuecomment-51862766.

rsandor commented 10 years ago

@willwhitney - Can you write up a rendering test for this in one or more of the time plot test suites? (see: tests/render/real-time/*.html)

willwhitney commented 10 years ago

Sure, be glad to.

On Thu, Aug 21, 2014 at 6:01 PM, Ryan Sandor Richards < notifications@github.com> wrote:

@willwhitney https://github.com/willwhitney - Can you write up a rendering test for this in one or more of the time plot test suites? (see: tests/render/real-time/*.html)

— Reply to this email directly or view it on GitHub https://github.com/fastly/epoch/pull/132#issuecomment-52991241.

filipstachura commented 10 years ago

Any updates here? It would be great to have that working!

rsandor commented 10 years ago

Ah sorry, was away for the last week or so. Looking into this now :)

rsandor commented 10 years ago

This looks good, merging and setting up a documentation ticket.

willwhitney commented 10 years ago

Great, thanks!

On Mon, Sep 8, 2014 at 6:43 PM, Ryan Sandor Richards < notifications@github.com> wrote:

Merged #132 https://github.com/fastly/epoch/pull/132.

— Reply to this email directly or view it on GitHub https://github.com/fastly/epoch/pull/132#event-162784744.

filipstachura commented 10 years ago

@rsandor thanks!