search

epochjs / epoch

A general purpose, real-time visualization library.
http://epochjs.github.io/epoch
MIT License
4.97k stars 278 forks source link

Remove absolute slash prefix from bower.json #171

Closed darklow closed 9 years ago

darklow commented 9 years ago

Looks like absolute prefix slash is redundant in your bower.json config. Therefore some other libraries fail to work nicely with epoch.

For example: https://github.com/ck86/main-bower-files/issues/85#issuecomment-100137353

I checked other bower libs and almost no one uses / prefix. Would you mind changing:

  "main": [
    "/epoch.min.js",
    "/epoch.min.css"
  ],

to

  "main": [
    "epoch.min.js",
    "epoch.min.css"
  ],

Thanks.

tep-pl commented 9 years ago

+1

Twintails commented 9 years ago

If you need the "/" in your final path string it should be trailing the predecessor. i.e. "some/path/to/" + "file.tld" or "include/javascripts/" + "*/.js

ref: font-awesome bower.json https://github.com/FortAwesome/Font-Awesome/blob/master/bower.json

The bower.json is telling the machine to look at the root directory. "/" = machine root please consider "./" to reference parent directory to the file or remove the "/" before the file name.

ex: "main": [ "./epoch.min.js", "./epoch.min.css" ], "license": "MIT", "ignore": [ "*/.", "./src", "./sass", "./tests", "./Cakefile", "./CHANGELOG.md", "./package.json" ]

rsandor commented 9 years ago

Fixed by #168