Update to d3 seems to have broken epoch

epochjs / epoch

A general purpose, real-time visualization library.

http://epochjs.github.io/epoch

MIT License

4.97k stars 279 forks source link

Update to d3 seems to have broken epoch #226

Open BenMcLean opened 7 years ago

BenMcLean commented 7 years ago

See changelog here: https://github.com/d3/d3/releases

v3.5.17 seems to be the last one that works.

darylldawn commented 7 years ago

Seconding this. After updating d3 to v4, epoch doesn't work since it uses d3.time.format, etc.

Thanks in advance!

skipzero commented 7 years ago

I take it that Epoch requires D3js < v4, from the above. Is the upgrade to v4 compatibility on the roadmap? Would be a handy thing to add to the docs, me thinks. Being new to Epoch, didn't think about at first and spent a little time wondering why it wasn't working.

beauremus commented 7 years ago

The documentation lays out how to fix the time issue. https://github.com/d3/d3/blob/master/CHANGES.md#timers-d3-timer I've done this locally and it works. There are other issues so as @zerosquadron asked, is there a roadmap for a d3 v4 rework?

rsandor commented 7 years ago

@beauremus - If you have fixed it locally, why not open a PR? I haven't had much time to work on Epoch as of late but I totally have time to review a PR or two 👍