epogrebnyak / ssg-dataset

Open reproducible dataset on static site generators (SSG) popularity.
https://ssg-dataset.streamlit.app
GNU General Public License v3.0
28 stars 47 forks source link

fix: switch from experimental_memo to cache_data #35

Closed Lewiscowles1986 closed 1 week ago

Lewiscowles1986 commented 1 week ago

I believe the docs say that this is the fix for the breakage I reported in #34

Fixes: #34

Screen-recording:

https://github.com/user-attachments/assets/d4232fd1-55a4-40fd-a525-7c2f0bf3a051

epogrebnyak commented 1 week ago

great, thanks, lets see if the app updates!

Lewiscowles1986 commented 1 week ago

Is there a reason it would?

I don't see any GitHub actions here, but I'm also incredibly gree on streamlit.

Thanks for the hint as to what might be wrong.

epogrebnyak commented 1 week ago

The streamlit app that is hosted on their cloud takes the code from the rpo, so on rerun or after sleep it takes newer code. Seems to work now - can you check?

Lewiscowles1986 commented 1 week ago

Yeah all working. Thanks.

epogrebnyak commented 1 week ago

Thanks for the patch!