epoplavskis / photon-pump

A TCP eventstore client for modern Python
MIT License
48 stars 9 forks source link

re-generate messages file #233

Closed bghitulescu closed 4 years ago

bghitulescu commented 4 years ago

We started seeing a log of errors like this

/usr/local/lib/python3.8/site-packages/photonpump/messages_pb2.py:538: DeprecationWarning: Call to deprecated create function FieldDescriptor(). Note: Create unlinked descriptors is going to go away. Please use get/find descriptors from generated code or query the descriptor_pool.
eventconsumer_1  |   _descriptor.FieldDescriptor(
eventconsumer_1  | /usr/local/lib/python3.8/site-packages/photonpump/messages_pb2.py:555: DeprecationWarning: Call to deprecated create function FieldDescriptor(). Note: Create unlinked descriptors is going to go away. Please use get/find descriptors from generated code or query the descriptor_pool.
eventconsumer_1  |   _descriptor.FieldDescriptor(
eventconsumer_1  | /usr/local/lib/python3.8/site-packages/photonpump/messages_pb2.py:572: DeprecationWarning: Call to deprecated create function FieldDescriptor(). Note: Create unlinked descriptors is going to go away. Please use get/find descriptors from generated code or query the descriptor_pool.

Currently photon-pump has a dependency on protobuf (protobuf>=3.5.1). When installing photon pump, the latest protobuf is installed (currently 3.12.2) and these errors start to popup. In order to fix this, this PR:

hjwp commented 4 years ago

@epoplavskis shall we merge and do a release?

epoplavskis commented 4 years ago

Yep, go for it