Open bopopescu opened 4 years ago
the tests are failing. I think master
may be hardcoded as a keyword somewhere in the protobuf protocol. if you can figure out where that is and do the translation main->master, then the build will probably pass again, and then i think we'd be happy to merge!
For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.