epoplavskis / photon-pump

A TCP eventstore client for modern Python
MIT License
48 stars 9 forks source link

ValueError: list.remove(x): x not in list #240

Open thomie opened 2 years ago

thomie commented 2 years ago

There is a bug in StaticSeedFinder, which results in the following error when running this test:

    def mark_failed(self, seed):
>       self._seeds.remove(seed)
E       ValueError: list.remove(x): x not in list

I'm not sure if the bug is in mark_failed (adding if seed in self._seeds: would fix it), or in add_node (perhaps discovered nodes should get added to self._seeds instead of self.candidates?), so I'm only providing a test at this moment.