epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.07k stars 59 forks source link

[Bug] Albums are mixed based on title only #370

Closed GioF71 closed 9 months ago

GioF71 commented 9 months ago

Hello, I have two albums with the same title from different authors. In lms I see one album entry with mixed contents from both actual albums. Of course they are located in different folders. Please tell me if I can provide more details to help you troubleshoot. I was using version "83347e8", the one you suggested me for the fix about mpd not being able to seek. I have just upgraded to 'latest' but the issue persists. Maybe do I need to do a full rescan?

Thank you!

epoupon commented 9 months ago

I used to answer to have to properly tag your data using MBIDs to handle this. But I will tackle this :) (same as #91 )

GioF71 commented 9 months ago

Thank you very much. The other user also will be probably happy. Still, your comment about tagging with MBID is very interesting, I will take a look. I am afraid of having to do mass re-tagging however...

Tolriq commented 9 months ago

As reference what I do after gathering tons of user feedback on this:

This is configurable and by default the split is done by folder + mbid, so handle most cases, and the users can tweak to their needs if it's specific.

image

epoupon commented 9 months ago

For now will do by mbid as it is today + fallback on the same album name only if it is in the same directory

Tolriq commented 9 months ago

Same as my default this covers 98% of the needs.

epoupon commented 9 months ago

Do you handle albums that are split on subfolders? (One subfolder per disc)

Tolriq commented 9 months ago

Not in the default configuration that's the 1%, users needs to uncheck folder and check album artist for those. (You can't properly detect those and just assuming a common parent folder may fail for other cases)

The other ones are people with all in the same folder without MBids, and got one user that split albums by artists and languages.

But with all the checkboxes I cover 100% of the reported needs.

GioF71 commented 9 months ago

I don't want to be the party pooper here, but won't 'splitting by folder' also split multi-disc albums into distinct albums? If so, maybe the last directory, if it starts with Disc, CD, etc etc should not be considered. This is how gonic does (see here), but as a result multi-disc album which have one subfolder per disc appear as distinct albums.

EDIT: you guys already mentioned the potential issue!

epoupon commented 9 months ago

Yes indeed, and you can also add mbids for these only 1% cases

GioF71 commented 9 months ago

Fair enough. What is the suggested strategy if we have multiple versions of the same album? Example a CDRip and a Digital Download. If you don't want to pollute the album title (which sometimes prevent that downstream last.fm cannot match the album correctly), is there a set of tags which can help distinguishing among such versions?

epoupon commented 9 months ago

They should have different release mbids then, but the same release group mbid. Lms UI does not group different releases that belong to the same group, but I would like to add this one day.

epoupon commented 9 months ago

@GioF71 could you give b02021a a try? It is published on docker hub

epoupon commented 9 months ago

(Well no, this version seems to be broken)

GioF71 commented 9 months ago

Hello and thank you, I tried that version and albums with same title were not mixed anymore. But I did not test it extensively yet!

GioF71 commented 9 months ago

Hello @epoupon, I was wondering, is there a chance that the very nice method of filtering results by tags you have built (by mood, etc) will be available, somehow, using the subsonic api? Or if it isn't, is it planned?

epoupon commented 9 months ago

Moods and genres are already exposed using the OpenSubsonic API. Edit: my bad, you meant filtering, this is discussed here: https://github.com/opensubsonic/open-subsonic-api/discussions/57 As said there, this would be quite straightforward for LMS to construct AND filters, as it is already done for the UI. I also plan to add languages, see https://github.com/opensubsonic/open-subsonic-api/discussions/66

The current "Tags" settings will be replaced by "Extra tags" or something like that, and LMS will always internally parse genres, moods and languages, needed by the OS API.

epoupon commented 9 months ago

Closing this as it is complete :) Feel free to open a discussion if you need to discuss something else

GioF71 commented 9 months ago

Hello, sorry I made a rescan, now I seem to have the opposite problem. I see multiple album entries for multidisc albums with all the tracks residing in the same folder...

GioF71 commented 9 months ago

Ups sorry my bad, I think that this was happening only 'during' the rescan, apparently the problem just went away immediately

GioF71 commented 9 months ago

Hello, sorry the problem is still happening. I just rescanned the library, and in the "Recently added" section, I find one instance of the album for each of its tracks. Is there something you might want me to do in order to provide useful information?

epoupon commented 9 months ago

You unfortunately tested a version with a bug. Does the file path contains _ in it ?

GioF71 commented 9 months ago

Yes it does :-(

epoupon commented 9 months ago

Ok so no new bug :) Can you live with it? Will hopefully issue a new release "soon"

GioF71 commented 9 months ago

sure, I will wait for the next release :-)

GioF71 commented 9 months ago

Hello, should I want to return to the 'latest' release, without completing resetting the configuration (users mainly), can I simply remove the db files? Or is it better to completely wipe the data folder? Thank you

epoupon commented 9 months ago

Hmm I think the current version you have has the same schema as the latest official one. So you can rollback the image and force scan to rescan everything

GioF71 commented 9 months ago

Hello, sorry for the late answer, that worked, thank you