epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.1k stars 62 forks source link

[Question] Issues with DSF file streaming #462

Closed GioF71 closed 4 months ago

GioF71 commented 4 months ago

Hello, and once again thank you for the great work. I am using the new feature you implemented, dsf support. For some reasons, I cannot properly stream a dsf file to mpd using my subsonic plugin for upmpdcli. The issue consists in the fact that mpd converts the stream to pcm for reasons I have not determined yet. The same does not happen when streaming from MinimServer. The subsonic plugin just serves an url to mpd: infact, if I feed the lms stream url to mpd directly using mpc (the command line client for mpd), the same problem happens, and in this case upmpdcli and the plugin are out out the scenario.

Checking the http headers of the url from MinimServer and comparing with the one from LMS, I see two main differences.

Content-Type is "audio/dsd" for LMS, while is "audio/x-dsf" for MinimServer. This looks more appropriate as it specifies more explicitly the format. Also, in minimserver, the header "Connection" is set to keep-alive. This one is missing in lms.

Do you see something wrong here, or something that can be done in order to fix the issue?

As a side note, I can tell you that mpd complains with a "ffmpeg/dsf: Estimating duration from bitrate, this may be inaccurate" message when I play those dsf files, however it does not complain similarly for any other file (flac namely), because in any case the duration information is set by the plugin.

Thank you

epoupon commented 4 months ago

Hello! Thanks for reporting, could you please check with image 02a0d4a5 ? In this, I changed the mime type accordingly.

GioF71 commented 4 months ago

Hello and thank you, I will probably in a few hours and report back to you.

GioF71 commented 4 months ago

Hello, I just tried, that worked perfectly! Amazing work!!!

epoupon commented 4 months ago

Thanks for testing!