search

epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.02k stars 60 forks source link

Multi-discs albums appearing once for each disc in the album entries #481

Open awsms opened 2 weeks ago

awsms commented 2 weeks ago

Screenshot from 2024-06-11 18-50-34 Screenshot from 2024-06-11 18-50-25 Screenshot from 2024-06-11 18-50-16

Folder structure:

The Dubliners - Complete Collection [FLAC]/
├── CD 1
├── CD 2
├── CD 3
└── CD 4

CD1 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=The Molly Maguires
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2006
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=1
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

CD2 Track 1 tags:

  comments: 13
    comment[0]: ARTIST=The Dubliners
    comment[1]: TITLE=Free The People
    comment[2]: ALBUM=Complete Collection
    comment[3]: DATE=2009
    comment[4]: TRACKNUMBER=01
    comment[5]: GENRE=Celtic
    comment[6]: PERFORMER=The Dubliners
    comment[7]: COMPOSER=
    comment[8]: ALBUMARTIST=The Dubliners
    comment[9]: DISCNUMBER=2
    comment[10]: TOTALDISCS=4
    comment[11]: TOTALTRACKS=20
    comment[12]: COMMENT=

Is there anything wrong here, or that's expected behaviour? I found https://github.com/epoupon/lms/issues/6, which implies multi-disc albums are well supported on LMS.

epoupon commented 2 weeks ago

Hello, Sorry for late response. For now, the only reliable way to group these discs is to use a musicbrainz release id. If this tag is not present, only the files in the same directory are considered to be part of the same album (and if the name of the album is the same, of course)

awsms commented 2 weeks ago

Mhh.. so LMS relies a LOT on MusicBrainz's metadata, as it's also the case for the dupechecker which simply checks a MB track id (and probably other things I haven't found yet). Shouldn't it be mentioned somewhere in the README? Because I pretty much assumed by reading it setting the same album tag & same album artist for files would group them (like it's the case with navidrome for ex.)

epoupon commented 2 weeks ago

Yes, it reliés a lot on MB (and it is assumed). You are right, this should be better stated in the readme file. That being said, we can try to improve the fallback behavior to handle more use cases :)