search

epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.08k stars 59 forks source link

Airsonic-Refix use of the getArtistInfo2 api #497

Closed GioF71 closed 1 month ago

GioF71 commented 1 month ago

Hello, I am using airsonic-refix on top of lms as you probably remember. I am encountering an issue when click on any Artist from the initial page of the application. To my understanding, this triggers a call to the getArtistInfo2 api. LMS seems to return a response that somehow Airsonic-Refix does not like. While examining navidrome's and lms's responses, it seems like the most important difference is with the musicBrainzId fields, which lms returns as a dictionary instead of a simple value. Also the entries in similarArtists are missing the "artistImageUrl" always comparing the response with Navidrome's. I am probably going to open an issue to Airsonic-Refix also, but of course any hint from your side can be very valuable. Thank you

epoupon commented 1 month ago

You mean lms returns an array of musicBrainzId to return the mbid of the artist? Will check this then, as this not compliant. About artistImageUrl, afair this is to put an external link (like a lastfm url), and lms does not support that. But this field should be optional, as some artists don't have images. My bet is rather that the mbid field makes airsonic-refix not working.

GioF71 commented 1 month ago

yes musicBrainzId is a dictionary from LMS. See:

image

it would be great if this is a non-compliance and that you can fix it. I also agree on the fact that the missing cover should not be the real issue here, as it should be optional!

GioF71 commented 1 month ago

Hello, thank you. it seems this is working. But now there is another issue with getTopSongs unfortunately. I will open another issue! Thank you for the great work!