epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.09k stars 61 forks source link

Artist covers, TZ and filesystem changes detection #499

Closed alscaldas closed 2 months ago

alscaldas commented 2 months ago

Hello,

I've been trying to use this server with Symfonium on my Android phone. I noticed that although the album covers are correctly displayed the artist covers aren't. Is there any further configuration I'm supposed to do in order to make it work? By the way, is it me or lms doesn't detect if a a file (most of my files are flac) has an embedded cover? I'm asking because I noticed that when I don't have a cover.jpg it just shows a folder.jpg or another equivalent on the folder, not the embedded picture.

Another question (not sure if I'm supposed to put both on the same issue) is the timezone. Mine is UTC -3, I'm running lms on a docker container and even if I use TZ=My/Timezone it still seems to show UTC time. Am I doing something wrong here?

Last, is there any other way to run sync than hourly? I mean, is there a way to lms detects changes in the filesystem and auto-sync?

By the way. It's really nice of you to feed the data from MusicBrainz syncs. I mean... I'm very used to my MPD + Cantata workflow on the desktop and to my surprise the scrobbles I was doing from Cantata to MusicBrainz were correctly detected and fed into lms. Really cool! :)

epoupon commented 2 months ago

Hello!

Lms is supposed to read both embedded and external cover files. Can you send me an offending file @ tmp49-tmp49@yahoo.com so that I can check on my side?

For artists, lms tries to read an artist.jpg file, expecting it to be placed at the longest common directory where the artist appears as a release artist. It can also read a file that has the artist mbid as name, that can be placed anywhere.

For tz, it is not supported yet (it is better to separate issues btw :))

For the hourly sync, I made some tests some time ago, using inotify, but I heavily refactored the scanner since... It would need some work but it is definitely doable.

alscaldas commented 2 months ago

Hey @epoupon, thank you for your prompt reply!

As for the album cover art there was no specific album. Any album whose folder didn't have an explicit cover.jpg file in it was showing one of the other picture files on the folder (not sure if it was folder.jpg or something). Anyway, now it's not happening anymore because I sort of got each one of them and downloaded the missing jpg pictures.

As for the artist covers, I just tried to name one as his mbid for testing and it worked nicely. Anyway, is it possible lms automatically download it from MB or TheAudioDB as long as I have a valid API key from these sources, or do I have to download each and every artist picture?

Again, I'm really enjoyng this MB synchronization!

epoupon commented 2 months ago

Thanks for your message.

I did not investigate much the artist image retrieval features. I have the feeling this should rather be done by some external tool (like a plugin of picard), as LMS is designed to only read the music and image files, it is not designed to modify tags or to add additional data inside the music directories. Looks like some people using navidrome tried to write scripts to automate this, maybe this could help you.

epoupon commented 2 months ago

Now related to #503