epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.14k stars 62 forks source link

Original Release date not always reading in Symfonium #506

Closed Bigmack3000 closed 3 months ago

Bigmack3000 commented 3 months ago

Archive.zip

Hey, it seems that symfonium doesn't always import the original release date tag from LMS. I've looked at the tags between the two examples I've attached, and can't find a difference.

For the example "Life on the Road", Symfonium imported the original release date tag from LMS. for "The Contenders" it ignored it.

Thanks!

epoupon commented 3 months ago

Your track only has the original year set (it is not a full date) Here is the response from LMS from this song (I don't set delimiters on my instance):

{
  "subsonic-response": {
    "openSubsonic": true,
    "serverVersion": "6",
    "status": "ok",
    "type": "lms",
    "version": "1.16.0",
    "album": {
      "artist": "The Kinks",
      "artistId": "ar-380407",
      "coverArt": "al-353997",
      "created": "2023-08-27T20:12:26.000",
      "displayArtist": "The Kinks",
      "duration": 302,
      "genre": "Garage Rock; Hard Rock; Pop Rock; Power Pop; Proto-Punk; Rock Music; Rock Opera",
      "id": "al-353997",
      "isCompilation": false,
      "mediaType": "album",
      "musicBrainzId": "af4a111e-2fc2-47fc-bdac-628fec518bf9",
      "name": "Sleepwalker",
      "playCount": 0,
      "played": "",
      "songCount": 1,
      "sortName": "",
      "year": 2010,
      "originalReleaseDate": {
        "year": 1977
      },
      "artists": [
        {
          "id": "ar-380407",
          "name": "The Kinks"
        }
      ],
      "discTitles": [],
      "genres": [
        {
          "name": "Garage Rock; Hard Rock; Pop Rock; Power Pop; Proto-Punk; Rock Music; Rock Opera"
        }
      ],
      "song": [
        {
          "album": "Sleepwalker",
          "albumId": "al-353997",
          "artist": "The Kinks",
          "artistId": "ar-380407",
          "bitDepth": 0,
          "bitRate": 320,
          "channelCount": 2,
          "contentType": "audio/mpeg",
          "coverArt": "tr-3031192",
          "created": "2023-08-27T20:12:26.000",
          "discNumber": 1,
          "displayAlbumArtist": "The Kinks",
          "displayArtist": "The Kinks",
          "duration": 302,
          "genre": "Garage Rock; Hard Rock; Pop Rock; Power Pop; Proto-Punk; Rock Music; Rock Opera",
          "id": "tr-3031192",
          "mediaType": "song",
          "musicBrainzId": "450d35aa-a9ac-4d02-bb1d-2d85088515b3",
          "path": "issue-506-original-release-date/01 Life on the Road.mp3",
          "playCount": 0,
          "played": "",
          "samplingRate": 44100,
          "size": 12145202,
          "suffix": "mp3",
          "title": "Life on the Road",
          "track": 1,
          "transcodedContentType": "audio/mpeg",
          "transcodedSuffix": "mp3",
          "type": "music",
          "year": 2010,
          "replayGain": {

          },
          "albumartists": [
            {
              "id": "ar-380407",
              "name": "The Kinks"
            }
          ],
          "artists": [
            {
              "id": "ar-380407",
              "name": "The Kinks"
            }
          ],
          "contributors": [
            {
              "role": "composer",
              "artist": {
                "id": "ar-388841",
                "name": "Ray Davies"
              }
            },
            {
              "role": "lyricist",
              "artist": {
                "id": "ar-388841",
                "name": "Ray Davies"
              }
            }
          ],
          "genres": [
            {
              "name": "Garage Rock; Hard Rock; Pop Rock; Power Pop; Proto-Punk; Rock Music; Rock Opera"
            }
          ],
          "moods": []
        }
      ],
      "moods": [],
      "releaseTypes": [
        "album"
      ]
    }
  }
}

Looks like it is ok, @Tolriq can tell what happens on Symfonium side.

epoupon commented 3 months ago

Ah, you say this one is correctly imported. Here is what I get for the other one, that has a full date:

{
  "subsonic-response": {
    "openSubsonic": true,
    "serverVersion": "6",
    "status": "ok",
    "type": "lms",
    "version": "1.16.0",
    "searchResult3": {
      "album": [
        {
          "artist": "The Kinks",
          "artistId": "ar-380407",
          "coverArt": "al-353998",
          "created": "2023-08-26T07:50:37.000",
          "displayArtist": "The Kinks",
          "duration": 162,
          "genre": "Pop Rock; Rock; Rock Music",
          "id": "al-353998",
          "isCompilation": false,
          "mediaType": "album",
          "musicBrainzId": "8be2c96d-d17d-46f4-9002-1ba3b4fc8dda",
          "name": "Lola Versus Powerman and the Moneygoround, Part One",
          "playCount": 0,
          "played": "",
          "songCount": 1,
          "sortName": "",
          "year": 2010,
          "originalReleaseDate": {
            "day": 27,
            "month": 11,
            "year": 1970
          },
          "artists": [
            {
              "id": "ar-380407",
              "name": "The Kinks"
            }
          ],
          "discTitles": [],
          "genres": [
            {
              "name": "Pop Rock; Rock; Rock Music"
            }
          ],
          "moods": [],
          "releaseTypes": [
            "album"
          ]
        }
      ]
    }
  }
}
Bigmack3000 commented 3 months ago

Yea the 2nd is the one not working properly. Does it matter that one is mp3 and one is m4a?

Bigmack3000 commented 3 months ago

Yea, looking though more albums that ignore "original release date" in symfonium, it looks like they are all m4a files.

Tolriq commented 3 months ago

I'm in holidays anything Symfonium related should be posted on Symfonium forum so I can look when back.

Bigmack3000 commented 3 months ago

Ok, I'll make a support post there as well. I wasn't sure if the issue was coming from LMS or symfonium

Bigmack3000 commented 3 months ago

Ok tolriq was able to look at it:

https://support.symfonium.app/t/origina-lrelease-date-not-always-recognized/4883/14

They say it's something on the LMS end.

epoupon commented 3 months ago

Are you sure of your songs? According to @Tolriq, you have a kind of duplicate song in your library that is badly tagged. The two songs you sent to me were properly tagged/handled.

Tolriq commented 3 months ago

Not what I said, I just said that there's 2 version of the album and for the one he is looking at, LMS does return an empty value for originalReleaseDate as seen in the JSON dump.

epoupon commented 3 months ago

Is this file part of the archive you posted?

Bigmack3000 commented 3 months ago

Not what I said, I just said that there's 2 version of the album and for the one he is looking at, LMS does return an empty value for originalReleaseDate as seen in the JSON dump.

Sorry if I misunderstood. I thought you were saying Symfonium is properly reading the information being supplied by LMS. So LMS must not be sending that info over.

Are you sure of your songs? According to @Tolriq, you have a kind of duplicate song in your library that is badly tagged. The two songs you sent to me were properly tagged/handled.

Yes I'm sure. I think they are referring to two different versions of the album. One is the orignal tracklisting. One is a deluxe edition. Both circled in this screenshot:

Screenshot_20240805_141633

The one down at the bottom are all mp3 files and the "original release date" tag was recognized in Symfonium. The one up top is m4a files, and the tag was not recognized.

Is this file part of the archive you posted?

Yes, i sent both the same two tracks. But i found that it's every album with m4a files.

Bigmack3000 commented 3 months ago

Just to further clarify, incase it's causing any confusion. There are times I have various versions/masters of the same album, but every thing is properly tagged through picard as their own individual album. And the LMS scans come back with 0 duplicate files in their report.

Bigmack3000 commented 3 months ago

Hey, just wondering if you've had a chance to look more into this? Thanks.

epoupon commented 3 months ago

Hello! No, I don't have access to a computer right now. You can have an idea of what lms parses using the command line tool, lms-metadata, which is inside the docker image.

Bigmack3000 commented 3 months ago

Sorry, i just don't know what I'd be looking for. I just know the tags are correct to whatever mbz says.

Bigmack3000 commented 3 months ago

Hey, I'm just checking in on this one again. Thanks!

epoupon commented 3 months ago

Ok, it looks like TagLib 2.0 (which is used in the docker image) now reads original date from "----:com.apple.iTunes:ORIGINALDATE" instead of "----:com.apple.iTunes:originaldate", but your file uses the last one.

epoupon commented 3 months ago

I have submitted a workaround on lms side, but the patch on taglib (https://github.com/taglib/taglib/pull/1184) seems to be questionable since my picard instance (2.12) does seem to write "----:com.apple.iTunes:originaldate" in your file (but maybe it keeps the tag intact since it is already here, I have not tested much).

Bigmack3000 commented 3 months ago

Thanks!