epoupon / lms

Lightweight Music Server. Access your self-hosted music using a web interface.
http://lms-demo.poupon.dev
GNU General Public License v3.0
1.15k stars 62 forks source link

Artists are not displayed with their final MB join phrase #528

Closed FibreTTP closed 2 months ago

FibreTTP commented 2 months ago

Context

Join phrases at the end of an artist credit on MusicBrainz are often used to add punctuation to extra artist information such as the Character Voice (CV.), the real life person voicing a character, in the form of: <Character Name> (CV. <Voice Actor>).

This is achieved on MusicBrainz by entering the following as the artist credit:

Artist as credited Join phrase
\<Character Name>  (CV.
\<Voice Actor> )

Issue

The join phrase of the final artist credit is either simply not displayed, or never entered into the database.

Given their rarity outside of this application, the only examples I have are ones in which the last join phrase is a single bracket, so I do not know if this only affects punctuation characters, or if it is all final join phrases that are affected.

Example

I have scanned this release into lms, which looks like this:

2024-09-22_16 35_firefox_ANymcT8z

Notice the final bracket is missing, where the MusicBrainz aritst credit looks like this:

2024-09-22_16 55_firefox_8A8B8NgC

This is the entire metadata from ffprobe:

Input #0, flac, from '01-01 ハニーシトロン.flac':
  Metadata:
    ACOUSTID_FINGERPRINT: AQADtImUqEkkJVOQuMSu4KWqgvkOT_rRjvnBZEf4HFqOfuBDgUniJSdKX1CV7HDT4NRwE6pzIdVznImUHReeY5KTbUEjPMSf43yGhFGKmFSHCzsTCs0zlInxNYe2H00cF7UOJqVUPEkSCSVB8dCPnzi65jluitin4JqhPsSzbMflFP2JJpnxJRwQJ_qDJGNRLkVj5cOlB_uyoAvJwzn6HHUiIlKqJcUzaKQOMVuORks7XHIenNCPJs-D8D3O4Xm
    ACOUSTID_ID     : 8541afd5-96d2-4a96-8a66-a4402a60d5ef
    ALBUM           : ハニーシトロン
    ALBUM ARTIST    : 神宮寺琉実 (CV.後本萌葉) & 神宮寺那織 (CV.内田真礼)
    album_artist    : 神宮寺琉実 (CV.後本萌葉) & 神宮寺那織 (CV.内田真礼)
    ALBUMARTIST_CREDIT: 神宮寺琉実 (CV.後本萌葉) & 神宮寺那織 (CV.内田真礼)
    ALBUMARTISTSORT : Rumi, Jinguji (CV.Nochimoto, Moeha) & Naori, Jinguji (CV.Uchida, Maaya)
    ALBUMARTISTS    : 神宮寺琉実;後本萌葉;神宮寺那織;内田真礼
    ALBUM_ARTISTS   : 神宮寺琉実;後本萌葉;神宮寺那織;内田真礼
    ALBUMARTISTS_CREDIT: 神宮寺琉実;後本萌葉;神宮寺那織;内田真礼
    ALBUMARTISTS_SORT: Rumi, Jinguji;Nochimoto, Moeha;Naori, Jinguji;Uchida, Maaya
    RELEASESTATUS   : Official
    MUSICBRAINZ_ALBUMSTATUS: Official
    RELEASETYPE     : single
    MUSICBRAINZ_ALBUMTYPE: single
    ARRANGER        : HIDEYA KOJIMA
    ARTIST          : 神宮寺琉実 (CV.後本萌葉) & 神宮寺那織 (CV.内田真礼)
    ARTIST_CREDIT   : 神宮寺琉実 (CV.後本萌葉) & 神宮寺那織 (CV.内田真礼)
    ARTISTSORT      : Rumi, Jinguji (CV.Nochimoto, Moeha) & Naori, Jinguji (CV.Uchida, Maaya)
    ARTISTS         : 神宮寺琉実;後本萌葉;神宮寺那織;内田真礼
    ARTISTS_CREDIT  : 神宮寺琉実;後本萌葉;神宮寺那織;内田真礼
    ARTISTS_SORT    : Rumi, Jinguji;Nochimoto, Moeha;Naori, Jinguji;Uchida, Maaya
    BARCODE         : 4540774740888
    BPM             : 0
    CATALOGNUMBER   : LAZC02839B00Z
    COMPILATION     : 0
    COMPOSER        : HIDEYA KOJIMA
    COMPOSERSORT    : Kojima, Hideya
    RELEASECOUNTRY  : XW
    DATE            : 2024-06-24
    YEAR            : 2024
    disc            : 1
    DISCTOTAL       : 1
    DISCC           : 1
    TOTALDISCS      : 1
    ISRC            : JPI102401478
    LABEL           : Lantis
    PUBLISHER       : Lantis
    LANGUAGE        : jpn
    LYRICIST        : ぽん
    MUSICBRAINZ_ALBUMARTISTID: 86a0651f-496e-468d-b3f7-dad008861120;6f9d42ee-c83e-4911-92ed-7de7abb28b54;6b482737-24db-4d03-ad84-2a5b65aae817;74368b3e-6a26-4e74-a210-e7e616fc49df
    MUSICBRAINZ_ALBUMID: 91576dbc-a0a6-4a00-b1ca-65e05c82dab7
    MUSICBRAINZ_ARTISTID: 86a0651f-496e-468d-b3f7-dad008861120;6f9d42ee-c83e-4911-92ed-7de7abb28b54;6b482737-24db-4d03-ad84-2a5b65aae817;74368b3e-6a26-4e74-a210-e7e616fc49df
    MUSICBRAINZ_RELEASEGROUPID: 2db20aa6-c012-4dd0-b791-3ca953717542
    MUSICBRAINZ_RELEASETRACKID: 8ad53197-7976-4f0f-8267-9d8c515aa44a
    MUSICBRAINZ_TRACKID: ec54c516-6cf4-411e-a289-e273ded6f355
    MUSICBRAINZ_WORKID: 376d3f1e-4257-4fbf-a311-f19d8b2322ad
    MEDIA           : Digital Media
    ORIGINALDATE    : 2024-06-24
    REPLAYGAIN_ALBUM_GAIN: -11.40 dB
    REPLAYGAIN_ALBUM_PEAK: 0.966051
    REPLAYGAIN_TRACK_GAIN: -11.40 dB
    REPLAYGAIN_TRACK_PEAK: 0.966051
    SCRIPT          : Jpan
    TITLE           : ハニーシトロン
    track           : 1
    TRACKTOTAL      : 1
    TRACKC          : 1
    TOTALTRACKS     : 1
epoupon commented 2 months ago

Thanks for reporting this! It is now fixed: image