botslib runscriptyield : 'txt' is not defined

eppye-bots / bots

Automatically exported from code.google.com/p/bots

63 stars 125 forks source link

botslib runscriptyield : 'txt' is not defined #382

Closed luckylud closed 6 years ago

luckylud commented 7 years ago

In the master branch, there is a omission in botslib.py:576 If a main() communication channel script not return an iterator, the error below will appear: DEBUG engine : Error in process: NameError: global name 'txt' is not defined

I often use pyflakes to check my python code, it's very very useful.

I've a fix, coming from bots 3.2

luckylud commented 7 years ago

diff --git a/bots/botslib.py b/bots/botslib.py index 2ea405c..ced8bcb 100644 --- a/bots/botslib.py +++ b/bots/botslib.py @@ -573,6 +573,7 @@ def runscriptyield(module,modulefile,functioninscript,argv): for result in functiontorun(argv): yield result except:

txt = txtexc() exception = ScriptError(('Script file "%(modulefile)s": "%(txt)s".'),{'modulefile':modulefile,'txt':txt}) _exception.cause = None raise _exception

luckylud commented 7 years ago

Arf ... diff display is ugly .. No patch or diff file could be send here ... it's so clean to work with git branch and merge a branch_fix pulled by someone.

eppye-bots commented 7 years ago

yes, saw that. thanks. henk-jan