search

epranka / scrollmagic-plugin-gsap

Add animation.gsap.js plugin to ScrollMagic in ES6 with no problems
MIT License
29 stars 5 forks source link

Tweenlite reference #6

Closed bleepsandblops closed 4 years ago

bleepsandblops commented 4 years ago

Hello,

Shouldn't this line https://github.com/epranka/scrollmagic-plugin-gsap/blob/master/index.js#L276 be Tween instead of TweenLite?

Cheers

epranka commented 4 years ago

Hi, probably yes. Source code is copied directly from https://scrollmagic.io/docs/plugins_animation.gsap.js.html

jcrain commented 4 years ago

I'm got a ReferenceError: TweenLite is not defined error.

Updated to Tween as @bleepsandblops suggested and is working now

jcrain commented 4 years ago

I created a PR for this fix, https://github.com/epranka/scrollmagic-plugin-gsap/pull/7

epranka commented 4 years ago

@jcrain thanks, I merged it, but I can't update it in npm repository. I do it in the evening

epranka commented 4 years ago

@jcrain @bleepsandblops Updated in npm registry too. Thanks for contribution.

jcrain commented 4 years ago

@epranka Have you tried to use the indicators plugin with this setup? I haven't had any luck yet.