search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
65 stars 42 forks source link

CCXT Pair Converter may not be available for people in the US #110

Closed macanudo527 closed 1 year ago

macanudo527 commented 1 year ago

It seems like the Binance Public API has been geolocked for the US. Since Binance is the default exchange for the CCXT pair converter, pricing might not be available for those using Dali-RP2 in the US.

We need another default exchange. Kraken is good candidate, but fetching pricing is really slow.

eprbell commented 1 year ago

What a pain in the neck... Kraken seems like a good alternative and hopefully caching will help with slowness issues.

eprbell commented 1 year ago

How much work is it to add the Kraken pair converter?

macanudo527 commented 1 year ago

It's just a simple line change. But, any prices from the last full quarter on (currently Q42022~) will take 5 seconds to retrieve.

The KuCoin API seems more responsive and has more markets, but prices start 9/2017. Kraken has a deeper history.

Can you access Binance's CSV files? Can you click the link and see if you are locked out? That is another option as well.

Obviously, it would beneficial for users to set this as a parameter as well.

eprbell commented 1 year ago

Should we implement #61 to fix this? That would give users full flexibility to choose what they want, I think. I can access the Binance CSV files you linked.

macanudo527 commented 1 year ago

This has been resolved with #115 .