Add Coinbase Pro pair converter

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.

https://pypi.org/project/dali-rp2/

Apache License 2.0

63 stars 42 forks source link

Add Coinbase Pro pair converter #150

Closed qwhelan closed 1 year ago

qwhelan commented 1 year ago

Add a new ccxt-based pair converter locked to Coinbase Pro. This requires a few changes:

Addition to _EXCHANGE_DICT
Override the default _TIME_GRANULARITY list when using Coinbase Pro, as it supports 6h instead of 4h: https://docs.cloud.coinbase.com/exchange/reference/exchangerestapi_getproductcandles
Upgrade ccxt to the minimum version with my fix for Coinbase Pro: https://github.com/ccxt/ccxt/pull/17646

macanudo527 commented 1 year ago

I'm doing a full pull now. I know there was an issue with CCXT and Binance.com. That is why we locked the version. If the pull works without issues, this should be good to go.

Sorry about the delay. We just went back to work after a major holiday here in Japan.

macanudo527 commented 1 year ago

This looks good to me. The pull was successful,

eprbell commented 1 year ago

This looks good to me. The pull was successful,

Great! @qwhelan, Github reports conflicts: after they are fixed we can merge.

qwhelan commented 1 year ago

@eprbell Rebased, conflict in setup.cfg should be resolved.