search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
63 stars 42 forks source link

Adding upbit exchange via ccxt #171

Closed topherbuckley closed 1 year ago

topherbuckley commented 1 year ago

As per Issue 159

@macanudo527 Seems to have worked. Is this the intended way of doing this though?

macanudo527 commented 1 year ago

This should work, but did you add the market? like you did for BOBA and XYM?

topherbuckley commented 1 year ago

@macanudo527, yeah I added them, and tested, but thought I'd keep those for a separate commit just to be cleaner as upbit support is separate from support of a specific coin, but happy to add that here as well if preferred. I just knew I'd have a bunch more pairs to add, so thought I'd combine all those added entries for a different commit.

topherbuckley commented 1 year ago

I just added the ARK/KRW pair, but let me know if you'd like me to take those back out and add back into a PR containing a bunch of other pairs I'll likely be adding.

topherbuckley commented 1 year ago

Sorry, was I supposed to add a subclass for each new exchange like is done here for binance, coinbase_pro, and kraken? Happy to do so, but wasn't sure if necessary or not (as code ran without them). I recall reading in another issue that these are for clarity, so happy to add them if needed.

Edit: nm, I think I realize now that those are for locking the pricing from one particular exchange (nothing to do with the alt exchanges functionality I was working with). I don't think anyone wants to lock to upbit, but happy to add if desired.

topherbuckley commented 1 year ago

I have a bunch more of these locally in their own linear branch history as separate branches. Do you want them in a single PR or each to their own?