search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
63 stars 42 forks source link

Automated reformat from black resulted in this #172

Closed topherbuckley closed 1 year ago

topherbuckley commented 1 year ago

Seems like a lot. Is this normal? I've never used black before, and was just following the unit tests on the dev README (in order) and it kept resulting in these changes, so thought I'd commit them.

If these aren't desired changes, should I try to learn about black and make any necessary changes to the config of how that is working? Any help in the right direction appreciated!

eprbell commented 1 year ago

No, it's all good: thanks for running black. I like having periodic black runs to ensure code is consistent style-wise. In this case the changes are mostly in newer files (Kraken), which makes sense, as they probably didn't go through black yet. However before merging, let's get @macanudo527's approval too, because he has a large PR in the pipeline and I don't want to make his life more difficult with too many conflicts.

macanudo527 commented 1 year ago

Yeah, this is all Kraken. It shouldn't affect my PR, I'll just have to add a blank optimize() to it.