DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
I fixed the line too long error via black, but there was also this error at the bottom of the report:
Exception ignored in: <generator object infer_attribute at 0x7f0afc6e36d0>
Traceback (most recent call last):
File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/astroid/inference.py", line 372, in infer_attribute
yield from owner.igetattr(self.attrname, context)
File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/astroid/bases.py", line 274, in igetattr
yield from _infer_stmts(
ValueError: generator already executing
Error: Process completed with exit code 16.
Not sure if this will show up again or not, but the closest thing I found was this closed issue in the pylint dev repo, which says this issue was resolved.
There was a mypy error that came after clearing the rest of the issues. I force pushed a rebase to take out the duplicate coinbase class def in the stub. That test just needs to be rerun (I ran it locally and it passed).
The alphabetical ordering (in addition to the one in the imports that you didn't mention in your review) was also pushed. Let me know if you need anything else on this.
I fixed the line too long error via black, but there was also this error at the bottom of the report:
Not sure if this will show up again or not, but the closest thing I found was this closed issue in the pylint dev repo, which says this issue was resolved.
There was a mypy error that came after clearing the rest of the issues. I force pushed a rebase to take out the duplicate coinbase class def in the stub. That test just needs to be rerun (I ran it locally and it passed).
The alphabetical ordering (in addition to the one in the imports that you didn't mention in your review) was also pushed. Let me know if you need anything else on this.