search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
65 stars 42 forks source link

fixed kraken:_initialize_markets and bug associated with Issue #161; #198

Closed ndopencode closed 1 year ago

ndopencode commented 1 year ago

added unit tests; original issue was due to ccxt versions differing in the data object for markets_by_id. Conformed kraken ccxt plugin to the latest ccxt version supported by DALI.

Closes https://github.com/eprbell/dali-rp2/issues/161

ndopencode commented 1 year ago

Looking at the unit test errors, I'm not sure how to address them since they are outside of the code of the kraken input plugin and its unit test. Locally, all CI checks pass without any failure so I'm not sure why the server CI system is not able to push through the "too many requests" error.

requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://api.exchangerate.host/symbols

macanudo527 commented 1 year ago

Looking at the unit test errors, I'm not sure how to address them since they are outside of the code of the kraken input plugin and its unit test. Locally, all CI checks pass without any failure so I'm not sure why the server CI system is not able to push through the "too many requests" error.

requests.exceptions.HTTPError: 429 Client Error: Too Many Requests for url: https://api.exchangerate.host/symbols

That test is just flakey. We will re-run it.

ndopencode commented 1 year ago

Updated per comments. Hope the CI checks are all green.

macanudo527 commented 1 year ago

@eprbell This looks good to me. I got the tests to pass.