eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
62 stars 41 forks source link

USD->EUR not found on any pair converter plugin #209

Closed lockevod closed 6 months ago

lockevod commented 9 months ago

Hello! Great tool! I'm using binance plugin and it's working fine but i've always this errror, I think it's clear but i don't know howto solve (I live in spain and we use EUR)

Regards

macanudo527 commented 9 months ago

Are you using the CCXT pricing plugin?

lockevod commented 9 months ago

Yes, i've check with binance lock, general conf and without any converter (default converter). I use -s option also.

My conf.

Data loaders

[dali.plugin.input.rest.binance_com sergi] account_holder = sergi api_key = XXXXXXXXX api_secret = XXXXXXXXXXX native_fiat=EUR

[dali.plugin.pair_converter.ccxt] historical_price_type = nearest default_exchange = Binance.com google_api_key = XXXXXXXXX

lockevod commented 9 months ago

The complet error is

ERROR: Fatal exception occurred: Traceback (most recent call last): File "/Users/sergi/crypto/dali-rp2/src/dali/dali_main.py", line 193, in _dali_main_internal resolved_transactions: List[AbstractTransaction] = resolve_transactions(transactions, dali_configuration, args.read_spot_price_from_web) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/sergi/crypto/dali-rp2/src/dali/transaction_resolver.py", line 259, in resolve_transactions transaction = _convert_fiat_fields_to_native_fiat(transaction, global_configuration) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/sergi/crypto/dali-rp2/src/dali/transaction_resolver.py", line 187, in _convert_fiat_fields_to_native_fiat raise RP2RuntimeError(f"Conversion rate for {transaction.timestamp_value}:{from_fiat}->{to_fiat} not found on any pair converter plugin") rp2.rp2_error.RP2RuntimeError: Conversion rate for 2023-08-29 23:05:58+00:00:USD->EUR not found on any pair converter plugin INFO: Log file: ./log/rp2_2023_10_03_12_31_35_596868.log INFO: Generated output directory: output INFO: Done

lockevod commented 9 months ago

If i change native_fiat=EUR => native_fiat=USD

I have the same error

macanudo527 commented 7 months ago

@lockevod this should have been resolved with #211 . Can you give it a try and let us know if you are getting correct pricing?

macanudo527 commented 6 months ago

I'm closing this as resolved. If the problem crops again, let use know.