search

eprbell / dali-rp2

DaLI (Data Loader Interface) is a data loader and input generator for RP2 (https://pypi.org/project/rp2), the privacy-focused, free, open-source cryptocurrency tax calculator: DaLI removes the need to manually prepare RP2 input files. Just like RP2, DaLI is also free, open-source and it prioritizes user privacy.
https://pypi.org/project/dali-rp2/
Apache License 2.0
62 stars 41 forks source link

Binance.US Implementation #228

Open tpaynter4 opened 3 months ago

tpaynter4 commented 3 months ago

Implement Binance.US Plugin

tpaynter4 commented 3 months ago

I just realized that the plugin does not load my deposits or withdrawals. Are deposits and withdrawals processed in the _process_fiat_order method?

macanudo527 commented 3 months ago

I just realized that the plugin does not load my deposits or withdrawals. Are deposits and withdrawals processed in the _process_fiat_order method?

They should be covered by the abstract plugin. Something might be wrong with the pagination details. You'll have to look into it. Is it missing fiat deposits and withdrawals only?

tpaynter4 commented 3 months ago

I believe it is only fiat.

macanudo527 commented 3 months ago

I believe it is only fiat.

OK, well, my guess is that there is an implicit API function that covers fiat withdrawal/deposit you will have to look up. This looks like it right here: https://docs.binance.us/#get-fiat-deposit-history

And the withdrawal Endpoint is there too.

tpaynter4 commented 3 months ago

The sapiGetFiatpaymentQueryWithdrawHistory and sapiGetFiatpaymentQueryDepositHistory end points are not available in the version of ccxt that dali-rp2 uses (3.0.79), but they are available in the current version (4.2.86). Is it possible to upgrade? Or would there be a way for me to use them with the current version?

macanudo527 commented 3 months ago

Yeah, that was on the todo list. Upgrades tend to break things. You can give it a try and I'll try with my exchanges as well, but these days I don't use as many advanced features.

Be sure to double-check all your math. If something doesn't look right, there is probably a bug. CCXT is pretty finicky.

savgrace commented 2 months ago

Is this ready to merge? I'm in need of a plugin for binance.us. If there's anything left to do I'd be happy help get this across the finish line with a few pointers :)

eprbell commented 1 month ago

@savgrace, thanks for offering to help (sorry, this fell through the cracks and I just noticed your message now). @tpaynter4 and @macanudo527, is there any way @savgrace can help with this?

tpaynter4 commented 1 month ago

I've been pretty busy lately, but I am still having problems with deposits and withdrawals. I think there are pagination issues when using the CCXT endpoints for deposits and withdrawals, but I am not sure.

macanudo527 commented 1 month ago

I've been pretty busy lately, but I am still having problems with deposits and withdrawals. I think there are pagination issues when using the CCXT endpoints for deposits and withdrawals, but I am not sure.

Have you looked at the API feed with Postman? In my experience, that has been a huge help for troubleshooting what the feed looks like.